developmentseed / developmentseed/mirror

Support Express >= 2.4.5

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Hi,

I see you are starting to support Express 2.5.x in Bones. But Mirror doesn't support Express >= 2.4.5. This is mainly because Express doesn't use `.call()` anymore. I'd be happy to commit patches if you can share your general ideas / thoughts.

FYI, Express's `History.md` says:

```
2.4.5 / 2011-08-19
==================

* Added support for routes to handle errors. Closes #809
* Added `app.routes.all()`. Closes #803
* Added "basepath" setting to work in conjunction with reverse proxies etc.
* Refactored `Route` to use a single array of callbacks
* Added support for multiple callbacks for `app.param()`. Closes #801
Closes #805
* Changed: removed .call(self) for route callbacks
* Dependency: `qs >= 0.3.1`
* Fixed `res.redirect()` on windows due to `join()` usage. Closes #808
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.