developmentseed / developmentseed/bones

Fragment handling for hash bang URLs

Open
#11 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
481
Forks
39
PR merge metrics
No merged PRs in 30d

Description

I just pushed a fix to fragment handling for hash bang URLs : 45becbc28e217066cabf6331fc61fa1abad95b9f

Basically two things were broken:
- the override to Backbone.history.saveLocation()
- getFragment() stripped out the `!` leading to mismatches of same URLs in `checkUrl()` (`!/path` != `/path`)

The fix brings extensive overrides to backbone which I'd rather avoid. The messiness stems from the fact that with hash bang (`#!`) URLs what's in the browser history (`!/path`) is different from the actual routes (`/path`) and thus non-JS fallbacks (`http://example.com/path`).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.