developmentseed / developmentseed/bones-document

Breaks: Document id same as attribute key

Open
#6 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4
Forks
2
PR merge metrics
No merged PRs in 30d

Description

A document with an id that is the same as an attribute id can't be edited - e. g. create a document with the id 'title' where the document contains an attribute 'title'. When going into edit mode, it will appear corrupted depending on the attribute level editors used in that document.

I have pushed a fix that breaks backwards compatibility:
https://github.com/developmentseed/bones-document/commit/744b12633a76dea4c516363bee60c9e407385268

This fix breaks backwards compatibility. Existing templates need to be updated and attribute keys need to be prefixed with `editable-` so that for instance the class `title` becomes `editable-title`.

Needs review.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.