developit / developit/unistore
skatejs support
- Dominant language
- JavaScript
- Stars
- 2.8k
- Forks
- 134
- PR merge metrics
- No merged PRs in 30d
Description
Just tried to take a stab at adding support for https://github.com/skatejs/skatejs but ran into a few issues:
1. Jest seems to not be friendly with custom elements since you cannot extend HTMLElement. I see https://github.com/jsdom/webidl2js/pull/88 and https://github.com/jsdom/jsdom/issues/1030 that have no positive resolution and require fundamental changes in jsdom.
2. What should an example of using unistore with a skatejs component look like? My current assumption is something like:
```
import { withComponent } from 'skatejs';
import { connect } from 'unistore/skatejs';
const actions = store => ({
// ...
});
class TestComponent extends connect('count', actions, withComponent()) {
render({ count }) {
return `Count is ${count}`;
}
}
```
Thoughts?
Thanks!
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.