developit / developit/undom

NodeList

Open
#34 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
690
Forks
25
PR merge metrics
No merged PRs in 30d

Description

I tried using this for a unit-test, and ran into some issues with e.g. `childNodes`, which in regular DOM is a [NodeList](https://developer.mozilla.org/en-US/docs/Web/API/NodeList) and not just an `Array`, which is missing, for example, the `keys()`, `values()` and `entries()` iterator methods.

I can foresee issues as well with e.g. `children` being a plain `Array` created by filtering `childNodes` - whereas, in regular DOM, mutating the `childNodes` of the parent that generated the `children` collection, would cause the iterator to reflect those changes.

Maybe this is "by design", favoring simplicity over correctness?

If so, that isn't clear from the "Project Goals" stated in the README right now - it doesn't seem to imply that this deviates from DOM in terms of more than features.

Lacking features is a matter of scope - but incompatibilities probably ought to be designated in the documentation?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.