developit / developit/preact-portal

Suggestion: blocking scroll

Open
#5 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
183
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Inspired by the use case of blocking scroll (also https://github.com/reactjs/react-modal/issues/60)

Should we consider adding events into Preact Portal or make it add a class to the `into`? events such as `onMount, onUnmount` (to their respective preact methods,) or a `preact-portal__shown` class...

I'm just asking, I'm creating my own component that extends PreactPortal to achieve this. Wondering if it's a valid use case.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.