developit / developit/preact-portal

`renderLayer` called on _every_ update?

Open
#17 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
183
Forks
23
PR merge metrics
No merged PRs in 30d

Description

The point of `` is to pass children to it (that are rendered somewhere else). And `props.children !== prevProps.children` always, right? If so, doesn't this mean that the for-if check in `componentDidUpdate` _always_ triggers?

https://github.com/developit/preact-portal/blob/ba212795be780de0d0a0c9725c69b1998e6f1123/src/preact-portal.js#L10-L16

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.