developit / developit/preact-markup

Default to HTML parsing?

Open
#11 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
207
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Leaving out `type="html"` causes [XML parsing](https://github.com/developit/preact-markup/blob/master/src/parse-markup.js#L12-L19), which breaks when the markup contains empty HTML elements that aren’t self-closed, e.g. ``, `
`, ``. This is especially problematic if the markup was generated by a Markdown processor (e.g. Marked does not self-close empty HTML elements). Due to this limitation, I think it makes sense to default to HTML parsing.

Related discussion in preact-markdown: https://github.com/laggingreflex/preact-markdown/issues/1#issuecomment-290517050

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.