devcontainers / devcontainers/spec

Question: how to go about making PR's regarding my changes

Open
#732 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
5.7k
Forks
496
PR merge metrics
No merged PRs in 30d

Description

Hey maintainers,

This is my first time contributing, so I wanted to know how to go about making a PR.
Because I kept running into some pet-pieves, so I thought I'd implement a few of them (see below).

Please let me know how you would like me to continue.

With kind regards,
\- 0wn

---

## Container name: [add-name-impl](https://github.com/0wnlife/devcontainer-cli/tree/add-name-impl)
### Which are mentioned in the following issues:
Although these issues are not a 100% match, they are requesting/mentioning wanting to be able to set/use container names. Since the spec already has a `name` in the devcontainer.json and it was easily obtainable via the config, I've simply made use of it by then adding the `--name ` to the docker/podman command.

#### devcontainers/spec
- [#184 — [proposal] Support for container name option in devcontainer.json](https://github.com/devcontainers/spec/issues/184)
- [#692 — Add support for command-line option for container name](https://github.com/devcontainers/spec/issues/692)

#### devcontainers/cli
- [#306 — `devcontainer up` should allow container name customization](https://github.com/devcontainers/cli/issues/306)

---

## Commands `stop`/`down`: [add-stop-down-command-impl](https://github.com/0wnlife/devcontainer-cli/tree/add-stop-down-command-impl)
### Which are mentioned in the following issues:

#### devcontainers/cli
- [#386 — Down command](https://github.com/devcontainers/cli/issues/386)
- [#1207 — [Feedback] Started using devcontainers last week, was looking for devcontainer down](https://github.com/devcontainers/cli/issues/1207)
- [#897 — When support devcontainer stop/down features](https://github.com/devcontainers/cli/issues/897)

#### devcontainers/spec
- [#694 — Status and Stop container, Destroy image](https://github.com/devcontainers/spec/issues/694)

---

## Node LTS 20 -> LTS 24: [update-node-lts-24](https://github.com/0wnlife/devcontainer-cli/tree/update-node-lts-24)
and while I was at it I've also updated node to the latest LTS version (24), because node 20 support will end pretty soon based on their [release schedule](https://nodejs.org/en/about/previous-releases)

---

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.