devcontainers / devcontainers/features

docker-outside-of-docker feature wrongly update container entrypoint

Open
#954 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
1.5k
Forks
621
Avg merge
2d 11h
Merged PRs (30d)
4

Description

in a dev container with **compose.yml** that use docker-outside-of docker feature [it updates the main entrypoint](https://github.com/devcontainers/features/blob/main/src/docker-outside-of-docker/devcontainer-feature.json#L44) which is not the expected result

with feature enabled
```sh
docker inspect --format='{{.Config.Entrypoint}}'
[
[/bin/sh -c echo Container started
trap "exit 0" 15
/usr/local/share/docker-init.sh
exec "$@"
while sleep 1 & wait $!; do :; done - /usr/local/share/docker-init.sh
]
```

without feature enabled
```sh
docker inspect --format='{{.Config.Entrypoint}}'
[
[/bin/sh -c echo Container started
trap "exit 0" 15

exec "$@"
while sleep 1 & wait $!; do :; done - /usr/local/share/docker-init.sh
]
```

**Solution**
use the `postStartCommand` instead

**Additional info**
maybe #483 it's related

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.