devcontainers / devcontainers/feature-starter

Clearer scenario names in tests

Open
#101 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
448
Forks
258
PR merge metrics
No merged PRs in 30d

Description

Only after finding [these docs](https://github.com/devcontainers/cli/blob/main/docs/features/test.md#scenarios) did I understand that this `hello`:

https://github.com/devcontainers/feature-starter/blob/67a45f05bb47843fef96f53ab09eab04680f6d95/test/hello/scenarios.json#L5

refers to the actual feature name, but this `hello`:

https://github.com/devcontainers/feature-starter/blob/67a45f05bb47843fef96f53ab09eab04680f6d95/test/hello/scenarios.json#L2

refers to the `hello` in the filename for [`hello.sh`](https://github.com/devcontainers/feature-starter/blob/main/test/hello/hello.sh) and not the command itself.

Okay with a PR to clarify and perhaps link to the test docs?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.