devcontainers / devcontainers/cli

Adding labels to containers build by devcontainer cli that are based on a Dockerfile (instead of an image) does not work

Open
#930 2 comments 5 reactions 1 assignee Claimed by @chrmarti View on GitHub
bug
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

A few months ago, the `--label` property to `build` was added that adds labels (https://github.com/devcontainers/cli/pull/846). Unfortunately it seems that this only works when a devcontainer is build that is based directly from an `image`. If it is based from a `Dockerfile`, the labels from `--label` are not added.
I added a test in a PR that shows the problem, see here: https://github.com/devcontainers/cli/pull/929

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.