devcontainers / devcontainers/cli

thrown value in `inspectDockerImage` obfuscates the underlying issue

Open
#642 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

The thrown value here (`err` instead of `_err`) obfuscates any error from the pull in the final result. The real error will be higher up in the logs, but it might be more helpful (especially in the codespaces case) to throw the result of the 'pull'. Eg:
```
Error response from daemon: Get \"https://mcr.microsoft.com/v2/\": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)\r\n`
```

https://github.com/devcontainers/cli/blob/efb3ffca505e252a58d8bf4d48da5ffe4becf0e2/src/spec-node/utils.ts#L237

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.