devcontainers / devcontainers/cli

devcontainer.json file's customizations of the project override feature's customizations

Open
#283 4 comments 0 reactions 1 assignee Claimed by @chrmarti View on GitHub
bug
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

When there are the same vscode settings in both feature's and the project's devcontainer.json file, the project's customizations override the feature's. Is it possible to merge it instead of an override?

- devcontainer.json file at the **features**:

```json
{
"customizations": {
"vscode": {
"settings": {
"files.associations": {
"LICENSE*": "plaintext"
}
}
}
}
}
```

- devcontainer.json file at the **project**:

```json
{
"customizations": {
"vscode": {
"settings": {
"files.associations": {
"commit-msg-template": "git-commit"
}
}
}
}
}
```

**Expected Result:**

```json
{
"customizations": {
"vscode": {
"settings": {
"files.associations": {
"LICENSE*": "plaintext",
"commit-msg-template": "git-commit"
}
}
}
}
}
```

**Current Result:**

```json
{
"customizations": {
"vscode": {
"settings": {
"files.associations": {
"commit-msg-template": "git-commit"
}
}
}
}
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.