devcontainers / devcontainers/cli

[Tracking] `devcontainer features test` improvements

Open
#139 5 comments 2 reactions 0 assignees View on GitHub
bug feature-request
Dominant language
TypeScript
Stars
3k
Forks
457
Avg merge
13h 17m
Merged PRs (30d)
6

Description

An issue collecting various improvements that can be made for the `features test...` command. The command is still experimental and under active development.

- [x] `remoteUser`, `containerUser`, or a container with a default non-root user are failing with a permissions issue when included in a scenario
- [x] Scenario tests appear to run as `root` even when `-u` specified in command line
- [ ] Feature values specified in scenario.json do not appear to be space escaped ("a b" ends up as "a")
- [x] `-f` prevents other parameters after it from being used since it treats them all as part of the array. Makes it impossible to pass in the require parameters.
- [x] Document all command functionality (ie: https://github.com/devcontainers/spec/discussions/113#discussioncomment-3830454) (https://github.com/devcontainers/cli/pull/219)
- [ ] If there is a scenario.json file and no test.sh, the test will not run unless `--skip-autogenerated` is set. We should be smarter about this
- [x] The one positional argument (path to collection) is required and doesn't use the default value (cwd)
- [x] Support `build.dockerfile` - Currently errors since Dockerfile referenced is not copied to temp location
- [x] Allow specifying a specific scenario to test via the CLI (helps if only one of several is failing)
- [ ] #438
- [ ] Output results to stdout so you can pipe to a log file w/o getting the entire build output (appears to go to stderr right now)
- [ ] Be able to override a certain base image <-> feature combos in the autogenerated tests (https://github.com/devcontainers/features/pull/116#pullrequestreview-1090984379)
- [x] https://github.com/devcontainers/cli/issues/163 / https://github.com/devcontainers/cli/issues/217
- [x] https://github.com/devcontainers/spec/discussions/114#discussioncomment-4031722
- [ ] https://github.com/devcontainers/cli/issues/334
- [ ] https://github.com/devcontainers/cli/issues/409
- [ ] https://github.com/devcontainers/cli/issues/448

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.