devantler-tech / devantler-tech/ksail

chore: remove loft-sh/log replace directive after upstream merges tablewriter v1.x

Open
#3,772 2 comments 0 reactions 0 assignees View on GitHub
blocked
Dominant language
Go
Stars
165
Forks
12
Avg merge
5h 51m
Merged PRs (30d)
347

Description

**Blocker:** loft-sh/log#3 | upstream | last-verified 2026-09-08: not shipped — re-checked against the Go module proxy: `@v/list` returns HTTP 200 with an **empty body** (the proxy knows the module and it still has no tagged versions; a 404 would mean unknown, so this is a meaningful negative) and `@latest` is the unchanged pseudo-version `v0.0.0-20260812120051-874a69680b18` (2026-08-12). A `replace` directive can only be dropped for a tagged release, so this stays blocked. The other half of the title remains satisfied: `olekukonko/tablewriter` shipped `v1.1.4` — it is the `loft-sh/log` tag that is missing.

## Description

Once [loft-sh/log#3](https://github.com/loft-sh/log/pull/3) is merged and tagged, the `replace` directive for `loft-sh/log` in `go.mod` can be removed entirely.

## Action Items

- [ ] Remove the `replace` directive and comment for `loft-sh/log` from `go.mod`
- [ ] Bump `github.com/loft-sh/log` to the new upstream version
- [ ] Remove `github.com/loft-sh/log` from `replace-allow-list` in `.golangci.yml`
- [ ] Run `go mod tidy`
- [ ] Verify `go build ./...` and `go test ./...` pass

## Context

- Upstream PR: https://github.com/loft-sh/log/pull/3
- KSail PR that replaced local fork with remote fork: #3771
- Original issue: #2246

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.