dethcrypto / dethcrypto/eth-sdk

Handling proxy contracts with implementation abi missing proxy abi

Open
#109 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
428
Forks
45
PR merge metrics
No merged PRs in 30d

Description

There is a proxy contract (https://etherscan.io/address/0x34460c0eb5074c29a9f6fe13b8e7e23a0d08af01) with implementation (https://etherscan.io/address/0x934ef5836e78d93125317034f5cf855a97b13f43). I'd like to use proxy contract methods in a type-safe way (in this case `getTarget` and `getMaster`). I would like to also use implementation methods in the same way. At this point, eth-sdk fetches only implementation abi, so I had to add missing proxy methods on my own.

This could be achieved if `noFollowProxies` could be defined for every contract separately instead of once for the whole config - I could then define two contracts (one with proxy abi and the other one with implementation abi). The other solution would be to allow abi merging - not sure how this would work precisely though.

What is your take on this?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.