dethcrypto / dethcrypto/eth-sdk
Does not work with Yarn Monorepos
- Dominant language
- JavaScript
- Stars
- 428
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
The CLI always generates files in `node_modules/.dethcrypto/eth-sdk-client` relative to the package.json
But in a Monorepo the package where I use eth-sdk might be in `packages/my-package`. So when I run the CLI it generates `packages/my-package/node_modules/.dethcrypto/eth-sdk-client` but it's looking for the package in `node_modules/.dethcrypto/eth-sdk-client`. This means eth-sdk doesn't work in Monorepos.
Also, the new version of Yarn doesn't encourage the use of `node_modules` anymore (https://yarnpkg.com/features/pnp) Maybe eth-sdk should have the option to be run in a mode where it generates source files that should be included in source control instead of creating another package.
Contributor guide
Assessment
This issue has not been assessed yet.