dethcrypto / dethcrypto/TypeChain

Event argument name conflicts with JS method values()

Open
#623 3 comments 0 reactions 1 assignee Claimed by @hasparus View on GitHub
bug
Dominant language
TypeScript
Stars
2.8k
Forks
376
PR merge metrics
No merged PRs in 30d

Description

Hi all,

I've just noticed that Openzeppelin's IGovernor.sol interface defines an event with argumetn `values` (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/governance/IGovernor.sol#L28-L37)

When I try to use the generated typings, I get that `event.args.values` is `undefined` - I believe this is because of the clash between the argument name and the JS object method `values()`

Is there a way to check for reserved keywords and pre/su-fix the name `values` with an underscore or something like that?

I can access it by index as well, but it would be messy to mix accesing content by `.` and `[]`. It might be also an issue for other reserved words.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.