dethcrypto / dethcrypto/TypeChain

Incorrect return type for web3-v1 events

Open
#400 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.8k
Forks
376
PR merge metrics
No merged PRs in 30d

Description

`web3.eth.Contract().events.SomeEvent(callback)` returns `Subscription` object but the generated return type is `EventEmitter`.

`typechain --target=web3-v1` generates this:
```typescript
export interface MyContract extends BaseContract {
events: {
SomeEvent(cb?: Callback): EventEmitter;
}
}
```
...but should generate this:
```typescript
export interface MyContract extends BaseContract {
events: {
SomeEvent(cb?: Callback): Subscription; // <--- different return type
}
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.