dethcrypto / dethcrypto/TypeChain

[web3@1.0.0] Generated typings don't have BigNumber as a type

Open
#103 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.8k
Forks
376
PR merge metrics
No merged PRs in 30d

Description

With `web3@1.0.0` as target, generated types no longer support `BigNumber` for the contracts. As an example, this is the typing generated with `web3@0.26.0` -- https://github.com/MARKETProtocol/types/blob/develop/types/MarketCollateralPool.ts#L178 and the below is generated using `web3@1.0.0` target which has `string` instead of `BigNumber` -- https://github.com/MARKETProtocol/types/blob/feature/upgrade-web3-1.0.0/types/MarketCollateralPool.d.ts#L44

`BigNumber` might need some additional parsing while generating the types I guess. Would be really great if this can be supported soon. Thanks :)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.