deso-protocol / deso-protocol/identity

Sometimes bitcloutToSellNanos is a negative number

Open
#57 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
69
Forks
64
PR merge metrics
No merged PRs in 30d

Description

I'm using bitclout/transaction.ts to parse raw transaction data into metadata using Transaction.fromBytes(txBytes)[0];

I'm converting transaction.ts into .js using command:

tsc bitclout/transaction.ts

It is mostly going very well. However, when parsing CREATOR_COIN transactions, I'm sometimes getting negative numbers.

For example for this transaction

https://explorer.cloutangel.com/tx/3JuEUYJmCwdXq9XtqAUZ9YLaEdz4HVbCmZEUKeMtJvN9jUd1tjz5Bg

The following values are produced -

bitcloutToAddNanos:0
bitcloutToSellNanos:-359050958
operationType:0
minCreatorCoinExpectedNanos:11479892781
minBitcloutExpectedNanos:0
creatorCoinToSellNanos:0

I'm guessing it's some problem with large numbers wrapping around -
Maybe related to this - https://github.com/bitclout/identity/pull/6/files ?

Any thoughts?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.