deso-protocol / deso-protocol/deso-js

Refactor to optimize tree shaking

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
10
Forks
6
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Right now the identity class has methods that depend on the ethers library. These methods are not useful for the typical app and should not require bundling the ethers lib if it's not needed.

**To Reproduce**
Run a build using any js bundler: webpack, rollup, esbuild, etc. After importing and using any identity method (login, logout, etc). If you check the bundled output it includes the entire ethers lib.

**Expected behavior**
If we don't require and use any ethereum related functions, we should be able to tree shake away the ethers dependency.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.