deso-protocol / deso-protocol/core

Invalid transaction signature when its VALID on quoted repost with Node key

Open
#264 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
327
Forks
106
PR merge metrics
No merged PRs in 30d

Description

This transaction has a valid signature, but the core says it's invalid.

We tried to do the same, but WITHOUT an extra data key (Node) passed, and the transaction passed through.

So my thoughts are somehow, when transaction parsed/converted to bytes again feels like the Node key missed and the signature checked using a wrong hash. But it's just thought from pattern we can see. Maybe wrong, but the issue persists when Node extra data key is presented in transaction.

Here is the transaction (inputs may or not be spent)

```
019b4fd0f7d2c8970b4e289d753ccb369dfdea11dca9ca012ce9a90ca3d123ee96010102a0b40718cf8e70aa2ac59236df101a9979ef0df756457cd239c74c9fb48cad99a9dfd56d05900100007f7b22426f6479223a224920626574205c22446973636f7665725c222077696c6c20626520746865206d6f7374206f6674656e20766973697465642070616765206f6e20404f766572636c6f7574206166746572206c61756e6368203a295c6e5c6e234f766572636c6f757420697320636f6d696e6720666f7220796f75227d904ed4618084a1fc9bfdb6ee16002102a0b40718cf8e70aa2ac59236df101a9979ef0df756457cd239c74c9fb48cad9903044e6f64650232360f497351756f7465645265636c6f75740101115265636c6f75746564506f73744861736820432d355a19f3487a8b5f639bf7e128dc8c6e1bece9acd160e6814aaacef35a1e4730450220687d524614a397c77070de2f72768b550008dc2c8494dae047897c9796070c30022100aa7945537bc8971ffe7ed30cd23a344e3de8098cc2ea61a8933152e7578bc06d
```

The result of submitting it

image

```json
{"error":"SubmitTransaction: Problem processing transaction: VerifyAndBroadcastTransaction: Problem validating txn: ValidateTransaction: Problem validating transaction: : ConnectTransaction: : _connectSubmitPost: : _connectBasicTransfer: Problem verifying txn signature: : RuleErrorInvalidTransactionSignature"}
```

It works when we are doing a normal post with Node extra key. When do quoted post with Node extra key – never works! We manually build transactions, so we take the signature of full hex with all data in without reparsing it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.