desktop / desktop/dugite

Proxy support seems to have regressed

Open
#498 4 comments 4 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
516
Forks
154
PR merge metrics
No merged PRs in 30d

Description

There's an old closed issue #148 where someone reported problems installing dugite behind a proxy. The recommended solution was to set `HTTP_PROXY`/`HTTPS_PROXY` which is also documented in the [environment variable docs](https://github.com/desktop/dugite/blob/main/docs/environment-variables.md#installation). It seems, however, that when dugite migrated away from `requests`, those environment variables stopped having any effect.

Now that dugite is using the raw `https` module, it looks like the easiest solution might be to add `global-agent` as a dependency and use it inside `download-git.js`. Here's [how `@electron/get` uses `global-agent`](https://github.com/electron/get/blob/c99de4bd1f8c21e4da98a4b8ac37012530e99c50/src/proxy.ts), for example.

If that solution makes sense (or if you can suggest another solution you'd prefer), I'd be happy to submit a PR.

Contributor guide

Open the contributing guide

Research direction

Start with download-git.js and the installation section of docs/environment-variables.md, then compare the current raw https usage with the linked @electron/get proxy.ts example. Confirm how HTTP_PROXY and HTTPS_PROXY are expected to affect downloads and define done as restoring proxy support without changing the documented environment-variable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
backend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.