report error to user when unable to save options
Open
Nobody has claimed this yet.
enhancement
not-planned
- Dominant language
- TypeScript
- Stars
- 21.9k
- Forks
- 10.6k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 25
Description
Description
Unable to change any settings, specifically change shell from Command Prompt to Powershell on Windows 10
Version
- GitHub Desktop: 1.2.6 - updated on 27.6.2018
- Operating system:
Windows 10
Steps to Reproduce
- Open Advanced Tab in options
- Click Save button after changing anything
Expected Behavior
Save of options did not do anything
Actual Behavior
Be able to change anything in the settings.
Additional Information
I have downloaded Github Desktop 1 week ago on my second computer. Since then this issue persisted. I have same version of Github Desktop on my first computer, and everything works fine.
Logs
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure by changing a setting in the Advanced tab and clicking Save on Windows 10, then inspect the attached production log for the save error. Done means a failed options save reports a clear error to the user instead of silently doing nothing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100