desktop / desktop/desktop

Image diff is displayed incorrectly for webp files.

Open
#18,517 2 comments 1 reaction 0 assignees View on GitHub
bug priority-3
Dominant language
TypeScript
Stars
21.8k
Forks
10.5k
Avg merge
1d 15h
Merged PRs (30d)
25

Description

### The problem

When viewing the difference for `.webp` files, only the _2-up_ view is working correctly (not sure about the _difference_ view). In both _Swipe_ and _Onion Skin_ views, the new version is displayed as old + new. The images below explain the issue more clearly.

Here is the _2-up_ view
![image](https://github.com/desktop/desktop/assets/27922283/b528180a-0753-4ed5-b84d-e7b9c0078bac)

Here is the _Swipe_ view
![image](https://github.com/desktop/desktop/assets/27922283/1e875770-61a3-48d8-8b55-061764ee788b)

Here is the _Onion Skin_ view
![image](https://github.com/desktop/desktop/assets/27922283/66609e02-e870-4c88-bb2f-9e3c8d64d880)

### Release version

3.3.14

### Operating system

Windows 11

### Steps to reproduce the behavior

1. Create a repo
2. Add a `.webp` image
3. commit your changes
4. Change the old `.webp` image
5. View the diff from _GitHub Desktop_

### Log files

_No response_

### Screenshots

_No response_

### Additional context

Here is the commit I took the screenshots from: https://github.com/espale-studios/website/commit/748296a6ea433f9a64705614437d6b52dfebf179

Contributor guide

Open the contributing guide

Research direction

No source files, tests, or entry points are named. First reproduce the issue in GitHub Desktop using the listed steps and a changed .webp image, then compare the 2-up, Swipe, and Onion Skin views; done means each view displays the new image correctly without combining old and new content.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.