desktop / desktop/desktop

Displayed errors from internally run tty's have broken encoding

Open
#16,892 1 comment 0 reactions 0 assignees View on GitHub
bug priority-3
Dominant language
TypeScript
Stars
21.8k
Forks
10.5k
Avg merge
1d 15h
Merged PRs (30d)
25

Description

### The problem

When app performs some operations in a terminal and encounters an error, the error message encoding can be broken, if the process inside the terminal used non-utf encoding.

F.e. upon performing a "commit", git hook can be invoked that throws an error, encoded in either win-1251 or cp-866 (cyrillic), but the display dialog assumes the text is in utf.

### Release version

3.2.3 (x64)

### Operating system

Windows 11

### Steps to reproduce the behavior

_No response_

### Log files

_No response_

### Screenshots

![image](https://github.com/desktop/desktop/assets/6272356/c83d02e9-4f64-41a4-9c92-70955ee09b91)

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.