desihub / desihub/desispec

fix pipeline steps that require fibermap to be sorted by FIBER

Open
#697 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
42
Forks
26
Avg merge
1d 20h
Merged PRs (30d)
11

Description

Some pipeline steps apparently make the assumption that `fibermap_row_index = FIBER%500` which is a fragile assumption. I've fixed that in a few places in desispec and desisim branches newfibermap, but I haven't found all cases. I don't have specific enough symptoms to know where without further debugging, thus this ticket. I have good redshift efficiency if the fibermap is sorted but terrible efficiency if it isn't, and it might be due to sky subtraction. TDB.

In the meantime desihub/fiberassign#147 restores the sorted order so that we can proceed with the pipeline testing.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.