M92 VAC (DR2)
- Dominant language
- Python
- Stars
- 7
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Contact Person: Amanda Byström
1 catalog file (fits), 1 README, tutorial in .ipynb + .html form.
Initial Checks:
- [X] Includes README
- [X] Columns in ALLCAPS
- [X] Extension names in ALLCAPS
- [x] Files include units
- [x] VAC publication passed CWR
Initial Notes:
* I suggest renaming this to "m92-survey". Typically, we do not include "vac" in the name, and the word "tertiary" is meaningful only internally to DESI.
* The FITS file has a number of inconsistencies. We definitely want units throughout, but in other cases it's a matter of picking a convention and applying it consistently to all HDUs.
- Although units are included in some HDUs, some columns in some HDUs that should have units do not.
- Some HDUs have DATASUM/CHECKSUM header keywords, but not all of them. For the HDUs that do have them, they are invalid.
- HDU 1 has TCOMMxx header keywords, but the other HDUs do not.
* The notebook should have a top-level title and meaningful subheadings, *i.e.* the layout should make sense when the outline view is opened.
* The README file only describes one of the 6 HDUs in detail. Nominally the other HDUs are based on https://desi-mws-dr1-datamodel.readthedocs.io/en/latest/rv_output/RVRUN/rvpix.html, but since this is DR2 data, are the HDUs based on the DR2 version of the MWS catalog?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the catalog FITS file and README, comparing all six HDUs for missing units, invalid or missing DATASUM/CHECKSUM keywords, and inconsistent TCOMMxx headers. Ask the named contact to confirm the DR2 data-model reference and proposed m92-survey name before proceeding. Done means consistent catalog metadata, README coverage of all HDUs, and a meaningful title and heading outline in the notebook and HTML tutorial.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter-notebook, python
- Domain
- data, documentation
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 46/100