desihub / desihub/desida

CIV Absorber VAC Review (Post-DR1 + DR2)

Open
#48 17 comments 0 reactions 0 assignees View on GitHub
vac review
Dominant language
Python
Stars
7
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Contact Person: Abhijeet Anand, @abhi0395
2 catalog files (fits), 1 README

Initial Checks:
- [X] Includes README
- [X] Columns in ALLCAPS
- [X] Extension names in ALLCAPS
- [X] Files include units
- [x] VAC publication passed CWR

Initial Notes:
* We need a "stub" name and version for this VAC, I suggest "civ-absorber/v1.0". Is this acceptable?
* `CIV_healpix-dr1-cat-v1.fits`
- HDU 0 has some non-trivial keywords, so it might be useful to add an EXTNAME to that HDU, *e.g.* 'PRIMARY'.
- In HDU `METADATA`, `EFFTIME` has units of `sec`, which is not valid in the FITS standard; `s` is the correct unit.
* `dr1-QSO_healpix_cat_for_CIV_search.fits`
- EXTNAME is not set for any HDU.
- In HDU 1, `EFFTIME` has units of `seconds`, which is not valid in the FITS standard; `s` is the correct unit.

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the README, then inspect the HDU names and EFFTIME units in CIV_healpix-dr1-cat-v1.fits and dr1-QSO_healpix_cat_for_CIV_search.fits. Review the existing discussion and confirm the proposed civ-absorber/v1.0 identifier and HDU naming expectations with @abhi0395. Done means the flagged metadata meets the agreed naming requirements and FITS unit standard, with the VAC identifier settled.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
54/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.