dequelabs / dequelabs/cauldron
Update button link classes to match our guidelines
- Dominant language
- TypeScript
- Stars
- 127
- Forks
- 31
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 8
Description
The current [`button.Link` selectors](https://github.com/dequelabs/cauldron/blob/61754b20d7a4ca320d0600047c0b959dd1427a4d/packages/styles/button.css#L48) should be changed to `.Button--link` to better match [our guidelines](https://github.com/dequelabs/cauldron/blob/develop/CONTRIBUTING.md#styles):
https://github.com/dequelabs/cauldron/blob/62c917271fd30df2e4e65c8eb421578ae20f373c/packages/styles/button.css#L44-L46
https://github.com/dequelabs/cauldron/blob/62c917271fd30df2e4e65c8eb421578ae20f373c/packages/styles/button.css#L231-L237
See: https://github.com/dequelabs/cauldron/pull/674#discussion_r898218217
NOTE: THIS IS A BREAKING CHANGE!
Contributor guide
Research direction
Open packages/styles/button.css at the cited button.Link selectors and compare them with the guideline examples linked in the issue. The work is complete when the selectors use the .Button--link naming consistently and the breaking change is reflected in the relevant stylesheet references.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100