dequelabs / dequelabs/cauldron

Allow button spacing to be configurable (or remove)

Open
#1,944 0 comments 0 reactions 0 assignees View on GitHub
tech debt ux debt
Dominant language
TypeScript
Stars
127
Forks
31
Avg merge
2d 12h
Merged PRs (30d)
8

Description

We have the following styles applied to adjacent buttons:

https://github.com/dequelabs/cauldron/blob/8bc06dcad8f0ac455107263b0f0bbf882e126afe/packages/styles/button.css#L250-L252

The problem with this approach, is that if buttons are placed inside of a flex/grid container with gaps, the margins will be inside of the gap created by styles. The only way to override this is by setting an overriding style which isn't ideal. We should consider allowing this to be controlled in the short term by allowing for the margins to be configurable OR don't apply margins at all and let authors decide how they want to space buttons.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.