dequelabs / dequelabs/cauldron

Keep attribution comments in SVG icons

Open
#1,653 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
127
Forks
31
Avg merge
2d 12h
Merged PRs (30d)
8

Description

When using Font Awesome Free and Pro SVG icons, we noticed the attribution comments are being removed. We need to keep this comment in the SVG file.

https://fontawesome.com/support#can-i-use-font-awesome-free-in-open-source-projects

> Heads up : [Font Awesome Free's license](https://fontawesome.com/license/free) requires that you maintain attribution when using Font Awesome assets.

https://fontawesome.com/license/free

> Attribution is required by MIT, SIL OFL, and CC BY licenses. Downloaded Font Awesome Free files already contain embedded comments with sufficient attribution, so you shouldn't need to do anything additional when using these files normally.

> We've kept attribution comments terse, so we ask that you do not actively work to remove them from files, especially code. They're a great way for folks to learn about Font Awesome.

See https://github.com/dequelabs/cauldron/pull/1649

## Resources
- https://svgo.dev/docs/plugins/removeComments/
- https://webpack.js.org/plugins/terser-webpack-plugin/#preserve-comments
- https://docs.fontawesome.com/web/use-with/react/

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.