dequelabs / dequelabs/axe-devhub-action

EPIC: gha comparison logic

Open
#115 3 comments 0 reactions 0 assignees View on GitHub
jazzband team-bass TYPE: task
Dominant language
JavaScript
Stars
0
Forks
5
PR merge metrics
No merged PRs in 30d

Description

When the GHA is ran, it is not taking into account the comparisons like it should. The below tickets will correct this logic error.

~TODO - the above logic needs to be changed a bit to reflect comparing to the common ancestor commit of the base branch, NOT the default branch. In order to do this, we will need to be grabbing the base branch from the git info and saving that as well as default branch info per commit. These tickets are on hold until this is thought out a bit further and the corresponding tickets are modified**~ EDIT: we are only comparing to the last scan of the default branch. We are trying to answer the question "how does my commit affect the current accessibility of the default branch?" so comparing to the last commit is the correct way to answer thing. No need to find a common ancenstor

```[tasklist]
### Tasks
- [ ] https://github.com/dequelabs/jazzband/issues/780
- [ ] https://github.com/dequelabs/walnut/issues/7236
- [ ] https://github.com/dequelabs/axe-devhub-action/issues/134
- [ ] https://github.com/dequelabs/jazzband/issues/1218
- [ ] https://github.com/dequelabs/jazzband/issues/1219
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.