dequelabs / dequelabs/axe-core

Don't fail ARIA attributes reflected from an invalid to a valid element

Open
#5,217 0 comments 0 reactions 0 assignees View on GitHub
fix rules
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 23h
Merged PRs (30d)
17

Description

Found this issue while benchmarking. The following shouldn't fail `aria-allowed-attr`:

```html

```

I think what to do here is, before Axe fails the element for having aria-required, check if any of its descendants has the same property AND value.

There are a few things to consider when fixing this:

1. Which attributes do we want to allow this on? All non-global, or maybe a more limited set?
2. Should we only allow this on generics like?
3. Do we want this to go to needs review?
4. What happens if multiple descendants have this prop?
5. Should Axe limit how far it searches?

Contributor guide

Open the contributing guide

Research direction

Start with the aria-allowed-attr rule and reproduce the provided custom-element markup, comparing the invalid text-field element with its input descendant. Resolve which attributes, element types, descendant depth, and duplicate-property cases are supported, then verify that the example no longer fails while unrelated ARIA violations retain their existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.