dequelabs / dequelabs/axe-core

ACT rule "Visible label is part of accessible name" (2ee8b8) changes break nightly

Open
#5,207 1 comment 0 reactions 1 assignee Claimed by @chutchins25 View on GitHub
fix label-content-name-mismatch tests
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 23h
Merged PRs (30d)
17

Description

Latest ACT update for our rule 2ee8b8 "Visible label is part of accessible name" has [added more examples](https://github.com/w3c/wcag-act-rules/blob/main/content/rules/2ee8b8/proposed.md) which are [breaking our nightly tests run](https://github.com/dequelabs/axe-core/actions/runs/29303327772/job/86991534641). The changes are non-trival as they follow a [new algorithm](https://github.com/w3c/wcag-act-rules/blob/main/content/rules/2ee8b8/proposed.md#label-in-name-algorithm-label-in-name-algorithm) which we don't implement. So things like removing all content between round brackets and maintaining space between spans are currently failing. [Our code currently uses visibleVirtual](https://github.com/dequelabs/axe-core/blob/develop/lib/checks/label/label-content-name-mismatch-evaluate.js#L45-L49) to generate the visible content, which we'll need to figure out if we want to continue to use that function or create a new function just for this algorithm.

This issue is linked to a `skipTests` entry in `test/act-rules/visible-label-in-accessible-name-2ee8b8.spec.js`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.