dequelabs / dequelabs/axe-core

Upgrade css-selector-parser

Open
#4,749 0 comments 0 reactions 0 assignees View on GitHub
breaking change tech debt
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 23h
Merged PRs (30d)
17

Description

`css-selector-parser` v3 is a breaking change in their API. Unfortunately we add the parser to the `imports` object of axe, meaning we can't upgrade to the latest without also creating a breaking change. We looked at creating a backwards compatible wrapper for the latest changes, but it was too much work and didn't work out to be 1:1.

We should upgrade to the latest non-breaking change version, then figure out how to handle the breaking change for v5. Either we remove the `imports` object from axe-core or just upgrade with a breaking change.

Ref: https://github.com/dequelabs/axe-core/pull/4264

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.