dequelabs / dequelabs/axe-core

link-in-text-block needs to take in to account other ways to underline links within text.

Open
#4,602 2 comments 0 reactions 0 assignees View on GitHub
fix high rules
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 23h
Merged PRs (30d)
17

Description

### Product

axe-core

### Product Version

4.10.0

### Latest Version

- [X] I have tested the issue with the latest version of the product

### Issue Description

#### Expectation
If I remove text decoration and use box shadow to underline link text within a paragraph of other text I should not the "Links must be distinguishable without relying on color" error from "link-in-text-block".

#### Actual
when I remove text decoration from a link that is other wise default and visually create an underline using box shadow I do get the error "Links must be distinguishable without relying on color" back from axe-core

#### How to Reproduce
Use this code to reproduce the issue --
```


This is some text in a paragraph before a link. And this is
a link with class="oj-link-embedded"
in a sentence. This is some text in a paragraph after a link


```
#### Additional context
Sometimes we need to do some animation effects so we aren't able to rely on text decoration for the underline. We have to do something more custom using box shadow. In the end the effect is the same visually in that that link appears as it would by default, complete with an underline. I think axe-core must be looking for text decoration among other variables to determine if the link looks different than the surrounding text. Could it also look for a box shadow effect?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.