dequelabs / dequelabs/axe-core

aria-required-attr should consider fallback values

Open
#4,481 1 comment 0 reactions 0 assignees View on GitHub
fix rules standards wai-aria
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 23h
Merged PRs (30d)
17

Description

In ARIA 1.2 the W3C removed all default values from properties that were set to be required. We updated axe-core accordingly, requiring attributes that had not been before. What we had missed is that after they did this, a table was added which re-introduced these default values as "fallback values" in a separate section of ARIA:

https://www.w3.org/TR/wai-aria-1.3/#document-handling_author-errors_states-properties

The example for which this came up was aria-level on role=heading. This should not fail axe-core. All major screen readers seem to report this as a level 2 heading:

```html

Hello world

```

Passing that doesn't seem like an issue. I'm much more concerned about having axe-core pass things like checkboxes without aria-checked, or a combobox without aria-controls or aria-expanded. Those will need more discussion. Looking at how ACT has done this, it has a similar rule which requires these things to be failed. It doesn't require these to be mapped to WCAG though, so if we wanted to stay consistent with ACT perhaps the best thing to do is for us to make this a best practice rule instead.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.