dequelabs / dequelabs/axe-core

Modal Dialog check thinks focus leaves dialog when it doesn't

Open
#3,380 8 comments 0 reactions 1 assignee Claimed by @scurker View on GitHub
extension
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 23h
Merged PRs (30d)
17

Description

Product: axe Extension

Expectation:

Using [`focus-trap`](https://github.com/focus-trap/focus-trap) to implement a dialog should return no issues with focus leaving the dialog.

Actual:

The Modal Dialog check is returning the issue "Keyboard focus is not maintained within the modal. It is possible to tab out of the modal". It does not give any insight into which element outside the dialog is able to be tabbed to. Considering I don't believe there are any elements outside the dialog that can be tabbed to (thanks to `focus-trap`), and I didn't see it tab to anything outside the dialog, this is either a faulty detection or it should provide more information for what element outside the dialog can be tabbed to.

Motivation:

I have no clue what element can be tabbed to outside the dialog, but presumably axe does know since it found one. It should tell me which element can be tabbed to outside the dialog.



axe-core version: 4.3.5
extension version: 4.22.1

Browser and Assistive Technology versions
Chromium: 98.0.4758.80

For Tooling issues:
- Platform: Linux

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.