dequelabs / dequelabs/axe-core

Normalize selectors to not be a mixed type

Open
#3,120 0 comments 0 reactions 0 assignees View on GitHub
breaking change core
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 13h
Merged PRs (30d)
29

Description

Currently our `target` selectors are a mixed type. It can be one of:

1. string
2. array of strings
3. both

This works fine in loosely typed languages, but in strictly type languages like Java and C# that doesn't work. We should change the selectors so it is a consistent type.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how axe-core represents and consumes `target` selectors; the issue names no files, tests, or entry points. Determine the consistent selector type required by the Java and C# integrations, then verify that string, string-array, and mixed inputs have one documented representation and matching behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, java, javascript
Domain
accessibility, api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.