dequelabs / dequelabs/axe-core

color-contrast-matcher is too greedy about excluding labels

Open
#2,372 0 comments 0 reactions 0 assignees View on GitHub
color contrast rules
Dominant language
JavaScript
Stars
7.5k
Forks
933
Avg merge
2d 23h
Merged PRs (30d)
17

Description

**Expected**: In the following code "hallo" and "guttentag" are tested for color contrast:

```html

Hello

Hallo

Guttentag

```

**Actual**: The color-contrast-matches method is a little greedy, and excludes everything that could be used in the accessible name computation as a disabled thing, not just whatever visible label is actually used. This may lead to things not being tested that probably should be.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.