dependency-check / dependency-check/DependencyCheck

Nexus/Central analyzers should fail hard when they cannot download some file

Open
#1,112 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
7.7k
Forks
1.4k
Avg merge
9d 22h
Merged PRs (30d)
13

Description

Excerpt from NexusAnalyzer:

} catch (DownloadFailedException ex) {
LOGGER.warn("Unable to download pom.xml for {} from Nexus repository; "
+ "this could result in undetected CPE/CVEs.", dependency.getFileName());
} finally {

In order to have stable scans, I would rather fail (i.e., throw an exception) at this point. Maybe this could be configurable, but I find this reasonable as the default behavior.

Without that, a connection issue can affect the build. That would be OK if that meant build failure (that is, ODC finds out that it misses some important information). This is not OK if it means that ODC pretends everything is OK.

EDIT: I have hit Enter prematurely…

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.