dependabot / dependabot/dependabot-core

Respect MSBuild property DirectoryPackagesPropsPath that overrides directory.packages.props name and location

Open
#9,696 4 comments 1 reaction 0 assignees View on GitHub
L: dotnet:nuget T: bug 🐞
Dominant language
Ruby
Stars
5.8k
Forks
1.5k
Avg merge
2d 18h
Merged PRs (30d)
149

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Package ecosystem

MSBuild

### Package manager version

_No response_

### Language version

_No response_

### Manifest location and content before the Dependabot update

.NET SDK allows Central Package Management file: `directory.packages.props` to be overriden thru MSBuild property: `DirectoryPackagesPropsPath` . The file name and path to it can be customized
Example:
`$([MSBuild]::NormalizePath('$(MSBuildThisFileDirectory)', 'foobar.props'))`

**Request for Dependabot to respect and make updates to file defined in `DirectoryPackagesPropsPath`**

### dependabot.yml content

_No response_

### Updated dependency

_No response_

### What you expected to see, versus what you actually saw

**Expected:** Dependabot respects path defined in `DirectoryPackagesPropsPath` and updates the file in its PRs
**Actual:** Dependabot only updates `directory.packages.props` in root directory or in parent directories of project.

### Native package manager behavior

_No response_

### Images of the diff or a link to the PR, issue, or logs

_No response_

### Smallest manifest that reproduces the issue

_No response_

Contributor guide

Open the contributing guide

Research direction

Search the Dependabot codebase for handling of directory.packages.props and DirectoryPackagesPropsPath, then trace how MSBuild manifests are located. Reproduce the example with a custom foobar.props path and verify that dependency updates target that file rather than only directory.packages.props in root or parent directories.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.