dependabot / dependabot/dependabot-core

Doesn't update versions in yarn resolutions

Open
#9,058 3 comments 3 reactions 0 assignees View on GitHub
T: bug 🐞
Dominant language
Ruby
Stars
5.8k
Forks
1.5k
Avg merge
2d 18h
Merged PRs (30d)
149

Description

### Is there an existing issue for this?

Duplicate of https://github.com/dependabot/dependabot-core/issues/2318#issuecomment-1939447694
But, that issue is incorrectly closed.

### Package ecosystem

npm

### Package manager version

yarn

### Manifest location and content before the Dependabot update

```
{
"name": "admin-js",
"version": "0.1.0",
"private": true,
"dependencies": {
"react": "^18.2.0",
"react-admin": "4.16.7",
"react-dom": "^18.2.0"
},
"devDependencies": {
"@testing-library/jest-dom": "^6.1.5",
"@testing-library/react": "^14.1.2",
"@testing-library/user-event": "^14.5.1",
"@ungap/structured-clone": "^1.2",
"jest-fail-on-console": "^3.1.2",
"react-scripts": "^5.0.1"
},
"resolutions": {
"create-react-admin": "4.16.7",
"ra-core": "4.16.7",
"ra-data-fakerest": "4.16.7",
"ra-data-graphql-simple": "4.16.7",
"ra-data-graphql": "4.16.7",
"ra-data-json-server": "4.16.7",
"ra-data-local-forage": "4.16.7",
"ra-data-local-storage": "4.16.7",
"ra-data-simple-rest": "4.16.7",
"ra-i18n-i18next": "4.16.7",
"ra-i18n-polyglot": "4.16.7",
"ra-input-rich-text": "4.16.7",
"ra-language-english": "4.16.7",
"ra-language-french": "4.16.7",
"ra-no-code": "4.16.7",
"ra-ui-materialui": "4.16.7"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build && (rm ../aiohttp_admin/static/*.js.map || true) && mv build/static/js/main.*.js ../aiohttp_admin/static/admin.js && mv build/static/js/main.*.js.map ../aiohttp_admin/static/ && rm -rf build/",
"test": "jest",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
],
"rules": {
"react/jsx-pascal-case": [1, {"allowLeadingUnderscore": true}]
}
},
"browserslist": {
"production": [
">0.2%",
"not dead"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
}
}
```

### dependabot.yml content

```
version: 2
updates:
- package-ecosystem: pip
directory: "/"
schedule:
interval: daily

- package-ecosystem: npm
directory: "/admin-js/"
schedule:
interval: daily
groups:
react-admin:
patterns:
- "create-react-admin"
- "ra-*"
- "react-admin"

- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "monthly"
```

### Updated dependency

```
{
"name": "admin-js",
"version": "0.1.0",
"private": true,
"dependencies": {
"react": "^18.2.0",
"react-admin": "4.16.10", <--- This is the only change
"react-dom": "^18.2.0"
},
"devDependencies": {
"@testing-library/jest-dom": "^6.1.5",
"@testing-library/react": "^14.1.2",
"@testing-library/user-event": "^14.5.1",
"@ungap/structured-clone": "^1.2",
"jest-fail-on-console": "^3.1.2",
"react-scripts": "^5.0.1"
},
"resolutions": {
"create-react-admin": "4.16.7",
"ra-core": "4.16.7",
"ra-data-fakerest": "4.16.7",
"ra-data-graphql-simple": "4.16.7",
"ra-data-graphql": "4.16.7",
"ra-data-json-server": "4.16.7",
"ra-data-local-forage": "4.16.7",
"ra-data-local-storage": "4.16.7",
"ra-data-simple-rest": "4.16.7",
"ra-i18n-i18next": "4.16.7",
"ra-i18n-polyglot": "4.16.7",
"ra-input-rich-text": "4.16.7",
"ra-language-english": "4.16.7",
"ra-language-french": "4.16.7",
"ra-no-code": "4.16.7",
"ra-ui-materialui": "4.16.7"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build && (rm ../aiohttp_admin/static/*.js.map || true) && mv build/static/js/main.*.js ../aiohttp_admin/static/admin.js && mv build/static/js/main.*.js.map ../aiohttp_admin/static/ && rm -rf build/",
"test": "jest",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
],
"rules": {
"react/jsx-pascal-case": [1, {"allowLeadingUnderscore": true}]
}
},
"browserslist": {
"production": [
">0.2%",
"not dead"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
}
}
```

### What you expected to see, versus what you actually saw

All versions in resolutions to be bumped as part of grouped update.

### Images of the diff or a link to the PR, issue, or logs

https://github.com/aio-libs/aiohttp-admin/pull/863/files

Contributor guide

Open the contributing guide

Research direction

Start with the /admin-js package manifest and dependabot.yml, focusing on the grouped npm update and its Yarn resolutions. Reproduce the update from react-admin 4.16.7 to 4.16.10 and trace the generated change; done means the grouped update also bumps the listed resolution versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, ruby
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.