denshoproject / denshoproject/densho-elastictools

Enable Query combination

Open
#2 0 comments 0 reactions 1 assignee Claimed by @gjost View on GitHub
enhancement
Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

`elastictools.search.Searcher.prepare` currently allows `match_all` search **OR** `fulltext` search **OR** `topics`/`facility` search. However `elasticsearch_dsl` allows `Q` objects to be combined. Why not support combinations of these searches? It'd be useful to be able to do a `fulltext` search within the context of a `topics` or a `creators` search, and vice versa.

We just can't break existing search behavior...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.