dense-analysis / dense-analysis/ale
eslint linter being run from wrong working directory
- Dominant language
- Vim Script
- Stars
- 14k
- Forks
- 1.5k
- Avg merge
- 17h 49m
- Merged PRs (30d)
- 1
Description
## Information
**VIM version**
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Aug 17 2022 21:21:22)
macOS version - arm64
## What went wrong
I would expect here that it find eslint and run it from the directory of the file being linted (IE `/Users/nipunn/src/convex/npm-packages/convex/src/cli/lib` in my case). However, I find that it's running it from the directory of the eslint inside node modules `/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0`
Here's a selected output from `:ALEInfo` with some newlines to make it more readable.
```
(started) ['/bin/zsh', '-c',
'cd ''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0'' &&
''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0/node_modules/eslint/bin/eslint.js''
-f json --stdin --stdin-filename ''/Users/nipunn/src/convex/npm-packages/convex/src/cli/lib/codegen.ts''
< ''/var/folders/jq/qm1fclpx4k5d9h3ytmsdtt3c0000gn/T/vZiEyDN/8/codegen.ts''']
```
Likely relevant is the way that rush uses symlinks to combine node modules in one place as so:
```
➜ convex git:(main) ✗ ls -l /Users/nipunn/src/convex/npm-packages/convex/node_modules/eslint
lrwxr-xr-x 1 nipunn staff 70 Oct 20 10:45 /Users/nipunn/src/convex/npm-packages/convex/node_modules/eslint -> ../../common/temp/node_modules/.pnpm/eslint@8.22.0/node_modules/eslint
```
Nonetheless, I think ALE should be able to be wise enough to go to the directory of the file being linted, rather than the directory eslint is installed.
## Reproducing the bug
1) Use the rush package manager
2) Create a project. Install eslint inside of it.
3) Open a file with vim.
### :ALEInfo
Expand
Current Filetype: typescript
Available Linters: ['cspell', 'deno', 'eslint', 'standard', 'tslint', 'tsserver', 'typecheck', 'xo']
Enabled Linters: ['cspell', 'deno', 'eslint', 'standard', 'tslint', 'tsserver', 'typecheck', 'xo']
Ignored Linters: []
Suggested Fixers:
'deno' - Fix TypeScript using deno fmt.
'dprint' - Pluggable and configurable code formatting platform
'eslint' - Apply eslint --fix to a file.
'prettier' - Apply prettier to a file.
'remove_trailing_lines' - Remove all blank lines at the end of a file.
'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
'tslint' - Fix typescript files with tslint --fix.
'xo' - Fix JavaScript/TypeScript files using xo --fix.
Linter Variables:
let g:ale_typescript_standard_executable = 'standard'
let g:ale_typescript_standard_options = ''
let g:ale_typescript_standard_use_global = 0
let g:ale_typescript_tslint_config_path = ''
let g:ale_typescript_tslint_executable = 'tslint'
let g:ale_typescript_tslint_ignore_empty_files = 0
let g:ale_typescript_tslint_rules_dir = ''
let g:ale_typescript_tslint_use_global = 0
let g:ale_typescript_tsserver_config_path = ''
let g:ale_typescript_tsserver_executable = 'tsserver'
let g:ale_typescript_tsserver_use_global = 0
let g:ale_typescript_xo_executable = 'xo'
let g:ale_typescript_xo_options = ''
let g:ale_typescript_xo_use_global = 0
Global Variables:
let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_disable_lsp = 0
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_insert_leave = 0
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let g:ale_linters_explicit = 0
let g:ale_linters_ignore = {'markdown': ['cspell'], 'python': ['pyright']}
let g:ale_list_vertical = 0
let g:ale_list_window_size = 10
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = v:null
let g:ale_open_list = 0
let g:ale_pattern_options = v:null
let g:ale_pattern_options_enabled = v:null
let g:ale_root = {}
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_info = '--'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = '--'
let g:ale_sign_warning = '--'
let g:ale_sign_highlight_linenrs = 0
let g:ale_statusline_format = v:null
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_virtualtext_cursor = 0
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
Command History:
(executable check - failure) deno
(started) ['/bin/zsh', '-c', 'cd ''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0'' && ''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0/node_modules/eslint/bin/eslint.js'' -f json --stdin --stdin-filename ''/Users/nipunn/src/convex/npm-packages/convex/src/cli/lib/codegen.ts'' < ''/var/folders/jq/qm1fclpx4k5d9h3ytmsdtt3c0000gn/T/vZiEyDN/8/codegen.ts''']
(executable check - failure) standard
(executable check - failure) tslint
(executable check - failure) typecheck
(executable check - failure) xo
(executable check - failure) cspell
(executable check - failure) deno
(finished - exit code 0) ['/bin/zsh', '-c', 'cd ''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0'' && ''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0/node_modules/eslint/bin/eslint.js'' -f json --stdin --stdin-filename ''/Users/nipunn/src/convex/npm-packages/convex/src/cli/lib/codegen.ts'' < ''/var/folders/jq/qm1fclpx4k5d9h3ytmsdtt3c0000gn/T/vZiEyDN/9/codegen.ts''']
<<>>
[{"filePath":"/Users/nipunn/src/convex/npm-packages/convex/src/cli/lib/codegen.ts","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[]}]
<<>>
(executable check - failure) standard
(executable check - failure) tslint
(executable check - failure) typecheck
(executable check - failure) xo
(executable check - failure) cspell
(executable check - failure) deno
(finished - exit code 0) ['/bin/zsh', '-c', 'cd ''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0'' && ''/Users/nipunn/src/convex/npm-packages/common/temp/node_modules/.pnpm/eslint@8.22.0/node_modules/eslint/bin/eslint.js'' -f json --stdin --stdin-filename ''/Users/nipunn/src/convex/npm-packages/convex/src/cli/lib/codegen.ts'' < ''/var/folders/jq/qm1fclpx4k5d9h3ytmsdtt3c0000gn/T/vZiEyDN/10/codegen.ts''']
<<>>
[{"filePath":"/Users/nipunn/src/convex/npm-packages/convex/src/cli/lib/codegen.ts","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[]}]
<<>>
(executable check - failure) standard
(executable check - failure) tslint
(executable check - failure) typecheck
(executable check - failure) xo
Contributor guide
Assessment
This issue has not been assessed yet.