dense-analysis / dense-analysis/ale

No response from puppet-languageserver

Open
#3,255 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Vim Script
Stars
14k
Forks
1.5k
Avg merge
17h 49m
Merged PRs (30d)
1

Description

## Information

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Jul 26 2020 22:02:15)
MS-Windows 64-bit GUI version with OLE support
Included patches: 1-1303

Operating System: Windows 10 1909

## What went wrong

Commands like `:ALEHover` or `:ALEGoToDefinition` does not work with puppet-languageserver. The process is starting properly but seems those commands does not work. It looks like the output form puppet-languageserver is empty so there is no action. I'm not sure how to troubleshoot that.

I use batch file as `puppet-languageserver` (version 1.0.0) command to wrap up the ruby execution. I can see that process is running properly.

```cmd
@echo off
REM this is for vim-ale support only
ruby c:\tools\puppet-editor-services\puppet-languageserver --puppet-settings=--modulepath,%cd%\spec\fixtures\modules %*
```

![image](https://user-images.githubusercontent.com/9575150/88903170-83963800-d253-11ea-9a36-5ceaa1ace908.png)

## Reproducing the bug

1. Install [puppet-languageserver](https://github.com/puppetlabs/puppet-editor-services)
2. Open any puppet type file
3. Run `:AleHover` or `:ALEGoToDefinition`

### :ALEInfo

ALEInfo
```
Current Filetype: puppet
Available Linters: ['languageserver', 'puppet', 'puppetlint']
Enabled Linters: ['languageserver', 'puppet', 'puppetlint']
Suggested Fixers:
'puppetlint' - Run puppet-lint -f on a file.
'remove_trailing_lines' - Remove all blank lines at the end of a file.
'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
Linter Variables:

let g:ale_puppet_languageserver_executable = 'puppet-languageserver'
let g:ale_puppet_puppet_executable = 'puppet'
let g:ale_puppet_puppet_options = ''
let g:ale_puppet_puppetlint_executable = 'puppet-lint'
let g:ale_puppet_puppetlint_options = '--no-autoloader_layout-check'
Global Variables:

let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '[%linter%][%severity%][%code%] %s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {'markdown': ['prettier', 'trim_whitespace', 'remove_trailing_lines'], 'ruby': ['rubocop', 'trim_whitespace', 'remove_trailing_lines'], 'yaml': ['prettier', 'trim_whitespace', 'remove_trailing_lines'], '*': ['trim_whitespace', 'remove_trailing_lines'], 'python': ['autopep8', 'isort', 'add_blank_lines_for_python_control_statements', 'trim_whitespace', 'remove_trailing_lines']}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_insert_leave = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {'python': ['pylint', 'pyls']}
let g:ale_linters_explicit = 0
let g:ale_list_vertical = 0
let g:ale_list_window_size = 10
let g:ale_loclist_msg_format = '[%linter%][%severity%][%code%] %s'
let g:ale_lsp_root = {}
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = v:null
let g:ale_open_list = 0
let g:ale_pattern_options = v:null
let g:ale_pattern_options_enabled = v:null
let g:ale_set_balloons = 1
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_info = '--'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = '--'
let g:ale_sign_warning = '--'
let g:ale_sign_highlight_linenrs = 0
let g:ale_statusline_format = v:null
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_virtualtext_cursor = 0
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
Command History:

(executable check - success) puppet-languageserver
(executable check - success) puppet
(finished - exit code 0) 'cmd /s/c "puppet parser validate --color=false C:\Users\pbugala\AppData\Local\Temp\VIB890C.tmp\packages.pp"'

<<>>

(executable check - success) puppet-lint
(finished - exit code 0) 'cmd /s/c "puppet-lint --no-autoloader_layout-check --log-format "-:%{line}:%{column}: %{kind}: [%{check}] %{message}" C:\Users\pbugala\AppData\Local\Temp\VIC890D.tmp\packages.pp"'

<<>>

(started) 'cmd /s/c "puppet-languageserver --stdio"'
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.