Wrong binaryen release downloaded for linux aarch64
- Dominant language
- TypeScript
- Stars
- 354
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
In the function `binaryenUrl` converts `aarch64` to `arm64` to produce the URL to download binaryen. This is the correct behviour for mac, but on linux the correct architecture label for `aarch64` releases is just `aarch64`.
https://github.com/denoland/wasmbuild/blob/816dc32252284c93b57e7b03cff7b61b43c74594/lib/wasmopt.ts#L124
The correct URL for linux aarch64 should be (assuming binaryen version_130):
https://github.com/WebAssembly/binaryen/releases/download/version_130/binaryen-version_130-aarch64-linux.tar.gz
not
https://github.com/WebAssembly/binaryen/releases/download/version_130/binaryen-version_130-arm64-linux.tar.gz
which is what is produced currently.
Contributor guide
Research direction
Start in lib/wasmopt.ts at binaryenUrl around line 124 and compare the architecture mapping for macOS and Linux. Verify that Linux aarch64 resolves to the Binaryen aarch64-linux archive URL rather than the arm64-linux URL, using the example in the issue as the expected result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, wasm
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 86/100